Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get opentelemetry trace id from request headers instead of creating a new trace #2648

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Get opentelemetry trace id from request headers instead of creating a new trace #2648

wants to merge 5 commits into from

Conversation

kozistr
Copy link

@kozistr kozistr commented Oct 15, 2024

What does this PR do?

Fixes #2376

I made a simple middleware to extract OpenTelemetry context (e.g. trace id, span id) from request headers. When valid transparent info is provided, then, it'll gonna use that context to create the span (if not, it'll generate its own as it does currently).

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@OlivierDehaene OR @Narsil

@kozistr
Copy link
Author

kozistr commented Oct 28, 2024

@Narsil @OlivierDehaene @ErikKaum hi! if you have the bandwidth, could you by any chance review this PR? thanks!

related PR: huggingface/text-embeddings-inference#425

OlivierDehaene
OlivierDehaene previously approved these changes Nov 21, 2024
View reviewed changes
@OlivierDehaene OlivierDehaene self-requested a review November 21, 2024 17:01
@OlivierDehaene
Copy link
Member

Sorry I was confused.
We already have a context extractor that we set here. It should already parse the W3C format and therefore the traceparent header so I'm not sure what exactly is the problem here.
Let me get back to you.

@kozistr
Copy link
Author

kozistr commented Nov 22, 2024

Sorry I was confused. We already have a context extractor that we set here. It should already parse the W3C format and therefore the traceparent header so I'm not sure what exactly is the problem here. Let me get back to you.

Hi. Thanks for the response.

from these two comments, #2376 (comment), #2376 (comment), I guess it seems the axum opentelemetry integration doesn't just do it automatically unlike most other frameworks. So, I just made a simple middleware to parse the traceparent header and manually inject it. please let me know if you find a better way to implement this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierDehaene OlivierDehaene Awaiting requested review from OlivierDehaene

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get opentelemetry trace id from request headers instead of creating a new trace
2 participants
@kozistr @OlivierDehaene